Skip to content

HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments#2745

Merged
aajisaka merged 3 commits intoapache:trunkfrom
aajisaka:test-YETUS-1102
Mar 11, 2021
Merged

HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments#2745
aajisaka merged 3 commits intoapache:trunkfrom
aajisaka:test-YETUS-1102

Conversation

@aajisaka
Copy link
Member

@aajisaka aajisaka commented Mar 5, 2021 •
edited
Loading

@asf-cloudbees-jenkins-ci-hadoop
Copy link

asf-cloudbees-jenkins-ci-hadoop bot commented Mar 5, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 34s Maven dependency ordering for branch
+1 💚 shadedclient 13m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 12m 57s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
56m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/1/artifact/out/Dockerfile
GITHUB PR #2745
Optional Tests dupname asflicense codespell shellcheck shelldocs
uname Linux d501b295ac26 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / f3eea10
Max. process+thread count 749 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

aajisaka commented Mar 5, 2021

The comment works as espected. I'm not sure why the vote is "💔 -1 overall"

@asf-cloudbees-jenkins-ci-hadoop
Copy link

asf-cloudbees-jenkins-ci-hadoop bot commented Mar 5, 2021

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 6s Maven dependency ordering for branch
+1 💚 shadedclient 13m 11s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 13m 3s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
44m 15s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/3/artifact/out/Dockerfile
GITHUB PR #2745
Optional Tests dupname asflicense codespell shellcheck shelldocs
uname Linux 3d8e89a4a2b0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 48eab3a
Max. process+thread count 721 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/3/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member

ayushtkn commented Mar 5, 2021

Hey @aajisaka
This looks good :-)
Mind raising a jira for the same, so as to get this in, or are we blocked on something?

@aajisaka
Copy link
Member Author

aajisaka commented Mar 8, 2021

YETUS-1102 is not merged into Yetus main branch. I'll push this.

@aajisaka aajisaka mentioned this pull request Mar 8, 2021
Merged
@aajisaka
Copy link
Member Author

aajisaka commented Mar 9, 2021

Filed https://issues.apache.org/jira/browse/HADOOP-17570.

We need to merge #2753 before this PR because Yetus dropped findbugs support before YETUS-1102.

@aajisaka aajisaka changed the title Test YETUS-1102 (Add an option to comment to GitHub PR) HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments Mar 9, 2021
@asf-cloudbees-jenkins-ci-hadoop
Copy link

asf-cloudbees-jenkins-ci-hadoop bot commented Mar 9, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-1 ❌ yetus 0m 5s Unprocessed flag(s): --findbugs-strict-precheck
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/4/artifact/out/Dockerfile
GITHUB PR #2745
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/4/console
versions git=2.25.1
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member

ayushtkn commented Mar 10, 2021

Seems it is throwing some error

Unprocessed flag(s): --findbugs-strict-precheck

@aajisaka
Copy link
Member Author

aajisaka commented Mar 11, 2021

bq. Seems it is throwing some error

It is as expected before #2753

@aajisaka aajisaka closed this Mar 11, 2021
@aajisaka aajisaka reopened this Mar 11, 2021
@ayushtkn
Copy link
Member

ayushtkn commented Mar 11, 2021

#2753 is merged right? Then why this problem is coming now?
Like here as well:
https://issues.apache.org/jira/browse/HDFS-15848?focusedCommentId=17299300&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17299300

@asf-cloudbees-jenkins-ci-hadoop
Copy link

asf-cloudbees-jenkins-ci-hadoop bot commented Mar 11, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 13m 29s Docker mode activated.
-1 ❌ yetus 0m 5s Unprocessed flag(s): --findbugs-strict-precheck
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/5/artifact/out/Dockerfile
GITHUB PR #2745
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/5/console
versions git=2.25.1
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@aajisaka
Copy link
Member Author

aajisaka commented Mar 11, 2021 •
edited
Loading

#2753 is merged right? Then why this problem is coming now?
Like here as well:
https://issues.apache.org/jira/browse/HDFS-15848?focusedCommentId=17299300&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17299300

Sorry I forgot to update the config in precommit-HDFS-build job after merging #2753. We have to sync the yetus options among Jenkinsfile and Precommit-HADOOP/HDFS/MAPREDUCE/YARN-Build jobs.

@asf-cloudbees-jenkins-ci-hadoop
Copy link

asf-cloudbees-jenkins-ci-hadoop bot commented Mar 11, 2021

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 20m 23s Docker mode activated.
-1 ❌ yetus 0m 5s Unprocessed flag(s): --findbugs-strict-precheck
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/6/artifact/out/Dockerfile
GITHUB PR #2745
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2745/6/console
versions git=2.25.1
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @aajisaka for fix,
We can see, the comments on the PR, so this fix is working.
+1 for this PR.

Try if you can get a comment without the yetus failure before merging.

@zhuqi-lucas
Copy link
Contributor

zhuqi-lucas commented Mar 11, 2021

Thanx @aajisaka for fix,
+1 for this PR.

@aajisaka aajisaka merged commit 9b78de2 into apache:trunk Mar 11, 2021
@aajisaka aajisaka deleted the test-YETUS-1102 branch March 11, 2021 12:48
@aajisaka
Copy link
Member Author

aajisaka commented Mar 11, 2021

Merged. Thank you @ayushtkn and @qizhu-lucas

aajisaka added a commit that referenced this pull request Mar 11, 2021
@aajisaka
HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments (#2745)
0c1ba49 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 9b78de2)
aajisaka added a commit that referenced this pull request Mar 11, 2021
@aajisaka
HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments (#2745)
6a24757 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 9b78de2)
(cherry picked from commit 0c1ba49)
aajisaka added a commit that referenced this pull request Mar 26, 2021
@aajisaka
HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments (#2745)
408cffe 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 9b78de2)
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@aajisaka
HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments (apache#2745
91e5d32 
)

Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
aajisaka added a commit that referenced this pull request Dec 28, 2021
@aajisaka
HADOOP-17570. Apply YETUS-1102 to re-enable GitHub comments (#2745)
112efdc 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
(cherry picked from commit 9b78de2)

 Conflicts:
	dev-support/Jenkinsfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aajisaka @ayushtkn @zhuqi-lucas